[vulkan] Fix stale GPU lifetime management tests for Vulkan.#8601
Merged
derek-gerstmann merged 3 commits intomainfrom Apr 2, 2025
Merged
[vulkan] Fix stale GPU lifetime management tests for Vulkan.#8601derek-gerstmann merged 3 commits intomainfrom
derek-gerstmann merged 3 commits intomainfrom
Conversation
Contributor
derek-gerstmann
commented
Mar 22, 2025
derek-gerstmann
commented
- Update string patterns to match output.
- Copy entry_point_name from module, since module may go out of scope prior to bindings if evicted from the shader compilation cache.
Update string patterns to match output. Copy entry_point_name from module, since module may go out of scope prior to bindings if evicted from the shader compilation cache.
mcourteaux
requested changes
Apr 1, 2025
Contributor
mcourteaux
left a comment
mcourteaux
left a comment
There was a problem hiding this comment.
Looks good, except the memory leak.
mcourteaux
approved these changes
Apr 1, 2025
Contributor
Author
|
Test branch failures are unrelated ... unrelated llvm20 internal asserts are being triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.